[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Multi-line property diffs on Win32 are diffed as a single-line ?

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2003-09-11 05:20:21 CEST

Ben Collins-Sussman wrote:

> "Francois Beausoleil" <fbos@users.sourceforge.net> writes:
>
>
>>Is that result expected, or should I file an enhancement or bug report ?
>
>
> The result is expected, only in the sense that our property diffing
> code is completely unaware of 'lines'. It just understands 'values'
> -- either two values are the same, or they're different, or one or
> both values is non-existent. It's pretty dumb code. It only knows
> how to print
>
> - oldvalue
> + newvalue
>
> or
>
> + newvalue
>
> or
>
> - newvalue
>
>
> So maybe we need an 'enhancement' request filed: property diffing
> code should stop treating all values as single units.

I actually filed an issue about what would be required to fix this, but
I think it's morphed somewhat so that it may no longer mention property
diffs anymore. The diff code currently can't just be run on two
arbitrary buffers (well, parts can, but the part that outputs the
unified diffs can't), so you can't easily use it to generate a diff
between two property values. I believe Sander is looking at fixing this
as part of making libsvn_diff more streamy, so once that's done it would
just be a 'small matter of programming' to fix the property diffs.

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 11 05:21:04 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.