Re: Volunteer for #872? (apr-iconv/xlate stuff, esp Win32)

Martin Hauner wrote:

> brane@xbc.nu wrote:
>
>> Here's what needs to be done with Issue #872:
>>
>> * Define two new charset conversion functions: one that converts
>> from the console input encoding to UTF-8, and one that converts
>> from UTF-8 to the console output encoding. On Unix, these will
>> just map to the existing to/from-UTF-8 functions.
>
> > * Change the Windows portion of svn_cmdline_init to stop calling
> > SetConsole[Outpu]CP, and instead call GetConsole[Output]CP and
> > store both values. These will be used by the two new functions.
> > * Use the new conversion functions wherever anything is printed to
> > or read form the console.
>
> I have already started on something like this. I have created an
> svn_console_string_from_native method that converts a string from the
> native locale to the console codepage.

I'm afraid you've misunderstood. You never have to convert from the
console encoding to the native encoding. The only conversions you need
are native<->UTF-8 (which we already have) and console<->UTF-8 (which we
don't)

On Unix, the console encoding is always the same as the native encoding,
so you don't need any new functions. On Windows, it depends on whether
the process actually has a console or not.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org