Why does "svn diff" forbid "-rCOMMITTED"?

What is the reason for this bit of code that forbids "-rCOMMITTED"? It does not forbid "-rPREV".

Index: subversion/libsvn_client/diff.c
===================================================================
--- subversion/libsvn_client/diff.c (revision 7005)
+++ subversion/libsvn_client/diff.c (working copy)
@@ -1743,11 +1743,6 @@
       || (revision2->kind == svn_opt_revision_unspecified))
     return svn_error_create (SVN_ERR_CLIENT_BAD_REVISION, NULL,
                              "do_diff: not all revisions are specified");
- if ((revision1->kind == svn_opt_revision_committed)
- || (revision2->kind == svn_opt_revision_committed))
- return unsupported_diff_error
- (svn_error_create (SVN_ERR_INCORRECT_PARAMS, NULL,
- "do_diff: COMMITTED nomenclature not supported"));

   /* Revisions can be said to be local or remote. BASE and WORKING,
      for example, are local. */

I have deleted this locally, and then it succeeds in a simple manual test of "svn diff -rCOMMITTED ...", and it passes all the regression tests.

It doesn't make sense to specify "COMMITTED" against a URL, but that's the same as with "PREV", and they generate the appropriate error message "need a version-controlled path to fetch local revision info.", so no problem there.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Sep 8 18:32:59 2003