[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: rev 6953 - in trunk/subversion: include libsvn_wc tests/clients/cmdline

From: Sander Striker <striker_at_apache.org>
Date: 2003-09-04 19:04:40 CEST

> From: Greg Stein [mailto:gstein@lyra.org]
> Sent: Thursday, September 04, 2003 2:38 PM

> On Wed, Sep 03, 2003 at 11:12:46PM +0200, Sander Striker wrote:
> > > From: Greg Stein [mailto:gstein@lyra.org]
> > > Sent: Wednesday, September 03, 2003 8:41 PM
> >
> > [...]
> > >> (svn_wc_revert): throw an error if trying to revert the current working
> > >> directory.
> > >
> > > Euh... why is this? It seems like an improper "fix". Why can't the current
> > > directory simply be unscheduled?
> >
> > There were two options, one was to throw an error if you are in a dir
> > you want to unschedule, the other was to walk up to the parent and unschedule
> > it there. Karl and I both thought that throwing the error was a good
> > solution since we have other commands that don't work from within the
> > target either.
>
> "the other was to walk up to the parent and unschedule it there" ... why?
> Is there "add" scheduling information in the parent that needs to be
> altered?

Yes, the parent has an entry for the subdirectory. The subdirectory, after
revert ., is not a working copy anymore. In other words, we've created
an obstruction.
 
> In any case, this is one of those cases where the software tells you
> exactly how to correct it, so the question is, "why didn't you just take
> those steps for me?"
>
> Maybe call it an enhancement, but the current behavior is a bit strange.

It depends. Regard these commands:

$ svn rm .
subversion/libsvn_wc/entries.c:1344: (apr_err=155013)
svn: Unmergeable scheduling requested on an entry
svn: fold_state_changes: '' is not a versioned resource

$ svn add .
subversion/libsvn_wc/lock.c:308: (apr_err=155007)
svn: Path is not a working copy directory
svn: '.' is not a working copy

Now, why would you expect 'svn revert .' to work when the operation
you are trying to revert didn't work from within the subdirectory?

OTOH, I hear your argument about the software knowing what to do.

Sander

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Sep 4 19:05:42 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.