Re: [PATCH] Re: Hooks on Windows

D.J. Heap wrote:

> Branko Čibej wrote:
> [snip]
>
>>
>> There's no reason to make this windows-specific. What we really want
>> here is an apr_file_open_null that returns a writable file to the
>> system-specific /dev/null, and use that. Unix people, do we have to
>> detect if /dev/null exists, or can we just fail if it doesn't?
>>
>>
> [snip]
>
> That sounds like a better idea. #ifdef's in code make me nervous.

For the interim, I'd suggest defining the name of the null device in
svn_private_config.h, for both Unix and Windows, then just use that
define, and the rest of your patch can remain unchanged.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org