[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Enhancing and possibly renaming svnadmin archive command(Scanned for viruses: Notes Admin)

From: <vberezniker_at_siuh.edu>
Date: 2003-08-05 16:34:10 CEST

It seems that my original email got lost on the way, so I am resending
it....

I would like to submit a patch to "svnadmin archive" command and its
underlying implementation in fs.c.

I. Enhancements:
----------------------------------------------------------

A). Add two new parameters to svn_fs_berkeley_archive to look as
follows:

    /** Set @a *logfiles to array of <tt>const char *</tt> logfile paths
     * of Berkeley DB-based Subversion filesystem.
     *
     * @a absolute_paths specifies format of the paths:
     * TRUE - Paths are to be absolute
     * FALSE - Paths are to be relative to the Berkeley DB logs
directory.
     *
     * @a all_log_files specifies which logs to include in the list:
     * TRUE - All logs are included
    * FALSE - Only unused logs are included
    *
    * This function wraps the same Berkeley DB 'log_archive' function
    * called by the db_archive binary. Repository administrators may
    * want to run this function periodically and delete the unused log
    * files, as a way of reclaiming disk space.
    */
    svn_error_t *svn_fs_berkeley_archive (apr_array_header_t **logfiles,
                                           const char *path,
                                          svn_boolean_t absolute_paths,
                                          svn_boolean_t all_log_files,
                                          apr_pool_t *pool);

B) Modify svnadmin's main.c to allow expose the new API to the end user.

II. Questions that came up:
----------------------------------------------------------

A). Name of the "archive" command.
    As Michael Wood pointed out that "archive" is not the best name to
describe the command that lists Berkeley DB log files.
http://article.gmane.org/gmane.comp.version-control.subversion.devel/31809
    * How does "svnadmin dbloglist [--all]" sound?
    * If command is renamed does svn_fs_berkeley_archive get renamed as
well or a new function is created (e.g. svn_fs_berkeley_loglist) and
svn_fs_berkeley_archive calls the new function so that any existing code
works without a change.?

B). cmpilato@collab.net said: "I don't really see the need to have the
abs-vs.-rel path parameter." referring to absolute_paths parameter.
http://article.gmane.org/gmane.comp.version-control.subversion.devel/31725

     * Given that I also want to submit a patch for "svnadmin copy" (hot
copy) command that will need log file names only, is that a reason enough
to keep that parameter? You can read about why I wish to compare log files
at
http://article.gmane.org/gmane.comp.version-control.subversion.devel/31740
 
I await your comments.

Sincerely,
Vladimir Berezniker

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 6 03:32:34 2003

This is an archived mail posted to the Subversion Dev mailing list.