[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Enhancing and possibly renaming svnadmin archive command

From: <cmpilato_at_collab.net>
Date: 2003-08-05 22:50:10 CEST

Vladimir Berezniker <vmpn@tigris.org> writes:

> > I still say it's kinda silly to have a parameter to toggle this since
> > we can always run over a list of relative paths and convert them to
> > absolute ones. Nevermind that Berkeley's log_archive() function would
> > be the one doing this work for us anyway -- from an API point of view,
> > it's just noise.
> >
>
> You are absolutely right, I misunderstood what you said last time. I
> read your comment to mean "returning absolute paths all the time", my
> mistake.

Well, even that would work fine. Relative path in that case would be:

   REPOS_PATH + "/db/" + svn_path_basename(abs_log_path);

But still, I say just fetch the names.

> How about another function, svn_repos_logfiles() that wraps
> svn_fs_berkeley_logfiles() and returns paths relative to the
> repository root.

Yes. This is the right thing to do. Doesn't bother me a bit.

> >> *
> >> * @a all_log_files specifies which logs to include in the list:
> >> * TRUE - All logs are included
> >> * FALSE - Only unused logs are included
> > I'd rather make the default answer contain all the log files, and
> > then have a parameter named 'ignore_unused' to toggle that behavior.
> >
>
> As I understand Berkeley DB, log_archive can return either list of
> unused logs or a list of used and unused log files.
>
> Of course a function that does (used and unused log files) - (unused
> log files) = (used log files) can be implemented.
>
> Is there a particular reason you want a list of only used log files?

Once again, we're running up against a place where a clean API
contradicts the main use-case. To name a function
svn_repos_logfiles() implies that those log files are actually
interesting. It's a weird scenario, if you think about it. We are
trying to name function which return a list of things we *want*, but
those things are the names of files that we *don't want*. :-)

You know, I can't bring myself to care about this. Do what you think
is right.

> Any chance end users might think "lslogs" has something to do with log
> messages? See above above regarding the "[--ignore-unused]" part.

Yes, good point. "lsdblogs" ?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Aug 5 22:52:54 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.