[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5677 - in trunk/subversion: include libsvn_wc

From: Greg Stein <gstein_at_lyra.org>
Date: 2003-04-29 00:38:43 CEST

On Fri, Apr 18, 2003 at 04:45:55PM -0500, kfogel@tigris.org wrote:
>...
> +++ trunk/subversion/include/svn_wc.h Fri Apr 18 16:45:54 2003
>...
> + * If @c svn_wc_adm_probe_open() succeeds, then add @a *adm_access to
> + * @a associated.

In most of these functions, 'associated' can be NULL, right? For example,
the first time you grab an access baton.

> + *
> + * Use @a pool only for local processing, not to allocate @a *adm_access.

Which then poses problems for this.

>...
> +++ trunk/subversion/libsvn_wc/lock.c Fri Apr 18 16:45:54 2003
>...
> + err = svn_wc_adm_probe_open (adm_access, associated,
> + path, write_lock, tree_lock,
> + svn_wc_adm_access_pool (associated));

And this is where it would presumably bomb, trying to get that pool.

What I don't understand is why it isn't crashing right now. If you do an
'svn add' of a single file, I would have thought that it would have crashed
since the associated set is NULL.

So... I'm a bit unclear on whether a problem truly exists, but it doesn't
feel quite right. Certainly, the expectation of being able to pass NULL to
some of these functions for the "associated" set is not very clear. Which
allow it, and which don't. (it looks like the retrieve functions will crash
if you pass NULL)

>...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Apr 29 00:38:10 2003

This is an archived mail posted to the Subversion Dev mailing list.