[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Compressed text-base patch

From: <rbb_at_rkbloom.net>
Date: 2003-04-28 23:42:28 CEST

> > As to why your commits fail, the problem is your use of
> > apr_file_data_get/apr_file_data_set. I do not know whether your
> > expectations are wrong, or whether the APR implementation is wrong,
> > but it appears that the data gets associated with the pool used by the
> > file, rather than with the file itself. This causes problems when two
> > files use the same pool.
>
> Yes I figured that out last night myself :) I think it's APR that's in
> the wrong here, since you would except the data to be associated with
> the file handle, not it's memory pool. Are there any APR developers
> on the list who think I'm wrong?

<rbb raises hand>

APR has called this out from the get-go. The data is associated with
whatever pool is used to open the file. The user-data stuff is an aspect
of pools, not every APR type. If we tried to associate the data with the
specific file handle, we would need a hash-table in every APR type, as
well as one in the pool. You must name your key so that it won't
interfere with other keys in the pool. This used to be very clearly
documented, but I haven't touched that code in well over a year, so I
don't know if it still is or not.

Ryan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 28 23:27:47 2003

This is an archived mail posted to the Subversion Dev mailing list.