Re: [RFC/PATCH] Revamping ra_svn tunnel agents

On Sun, 2003-04-27 at 01:31, Greg Hudson wrote:
> mbk weighed in in favor of svn:scheme: over IRC, and I don't have a
> strong opinion, so it's currently 2 to 0 for svn:scheme:. So if you
> had your heart set on svn+scheme:, speak up soon or suffer the agony
> of witnessing an improperly painted bikeshed.

Of course it couldn't be that simple.

Right now, we decide if an argument looks like a URL by seeing if it
contains a "://" before the first "/" or ":" character.
"svn:scheme://blah" doesn't work.

The most general way to recognize a URL is to see if it starts with a
valid scheme part followed by a colon, which would also match almost any
pathname with a colon in the first path element. If we ever want to be
able to check out anything like "isbn:1584790830", we'll have to make
that sacrifice. (Uh, and I guess we'd want to make a special exception
for Windows drive letters.)

A compromise is to just look for "://" without worrying about what comes
before it. This has the benefit of reducing svn_path_is_url to a single
line of code.

Opinions?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Apr 27 08:15:19 2003