[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 5717 - trunk/subversion/libsvn_client

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2003-04-24 14:39:04 CEST

rooneg@tigris.org writes:

> Author: rooneg
> Date: Wed Apr 23 20:08:05 2003
> New Revision: 5717
>
> Fix the new export editor's handling of files with svn:keywords set.

Thanks so much, Garrett!

>
> + /* We need to keep this around so we can explicitly close it in close_file,
> + thus flushing it's output to disk so we can copy and translate it. */
> + apr_file_t *tmp_file;

Ah, I understand now. I guess it the file was only implicitly flushed
and closed when the editor-driver freed the file_baton's pool. Makes
sense.

> + apr_status_t apr_err = apr_file_close (fb->tmp_file);

A random question: when the window handler receives a NULL window
(meaning it's done), couldn't it just close the *stream* it's been
writing to? Then only the handler baton would need a new field, not
the file baton.

> - svn_subst_keywords_t *final_kw = apr_pcalloc (pool, sizeof(*final_kw));
> + svn_subst_keywords_t final_kw;
>
> if (fb->eol_style_val)
> svn_subst_eol_style_from_value (&style, &eol, fb->eol_style_val->data);
>
> if (fb->keywords_val)
> - build_final_keyword_struct (fb, final_kw, pool);
> + build_final_keyword_struct (fb, &final_kw, pool);

Does this really work? The helper function assumes that final_kw has
had all its fields initialized to NULL.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Apr 24 14:40:44 2003

This is an archived mail posted to the Subversion Dev mailing list.