Re: svn commit: rev 5608 - trunk/subversion/bindings/swig

Greg Stein <gstein@lyra.org> writes:

> > Isn't there a more correct (albeit more complex) way to do this using
> > 'enum SWIGTYPE'? Not that I'd change this fix if it works, mind you
> > -- just wondering.
>
> Yah, there is. Look at the code just below that, for svn_filesize_t.
> Basically, we'd just define the actual code to do the mappings.
>
> In the %apply case, however, we get to use whatever was defined for the
> 'unsigned int' type (in this case). Whether that's the Python, Java, or
> whatever language's code.
>
> A tradeoff. I just applied the thing to get it to work. Didn't put too much
> brainpower into it, since the enum and unsigned int types are compatible.
> I'd be totally fine if it gets expanded out to the "right" code.

Well, I was about to commit the typemap creation (did the work Friday
on the train home) anyway, so since you're cool with it, I'll commit
the "right"* code.

--C-Mike

*where "right" means "correct in spirit if not in substance".

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Apr 14 17:22:55 2003