Re: svn commit: rev 5444 - in trunk/subversion: libsvn_subr tests/libsvn_subr

dlr@tigris.org wrote:

>Author: dlr
>Date: Mon Mar 24 10:24:58 2003
>New Revision: 5444
>
[snip]

>@@ -401,11 +514,12 @@
> {
> if (cfg)
> {
>- cfg_option_t *opt = find_option (cfg, section, option, NULL);
>+ cfg_section_t *sec;
>+ cfg_option_t *opt = find_option (cfg, section, option, &sec);
> if (opt != NULL)
>- make_string_from_option (valuep, cfg, opt);
>+ make_string_from_option (valuep, cfg, sec, opt, NULL);
> else
>- *valuep = default_value; /* ### TODO: Expand default_value */
>+ expand_option_value (cfg, sec, default_value, valuep, cfg->x_pool);
>

Hmm, this slipped through my review. Did you run the tests with this
change? Because, if find_option returns NULL and default_value doesn't
get expanded, this last line sets valuep to NULL instead of
default_value, thus causing all sorts of havoc.

I'm fixing this now.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org