Re: svn commit: rev 5399 - trunk/subversion/tests/clients/cmdline/svntest

On Sun, Mar 23, 2003 at 10:37:16PM +0100, Branko ??ibej wrote:
> B. W. Fitzpatrick wrote:
> >>brane@xbc.nu writes:
>...
> >>A bit of history: We used to explicitly check for SVNTreeUnequal in
> >>TestCase::run, print something, and convert it to an error code. Now, we
> >>only catch svntest.Failure, and print out the message it contains (if
> >>any): I defined __init__ in the SVNTree* classes that way so that we
> >>still print something for non-generic exceptions.

Good point, but it was simply replicating information that was already
available, so it seemed awfully redundant. It also printed out quite funny
by the traceback mechanism. So... out it goes :-)

Missed the part about TestCase.run, tho :-) Check out rev 5440; that should
fix your concerns.

>...
> Sure, the __init__ definitions arent *necessary*, but they preserve
> behaviour we used to have. If people decide we don't need that behaviour
> -- fine. I'd just point out that we don't print a stack trace when we
> catch those exceptions, so printing the exception type might be nice.

Other ways to do it, rather than to push it back on the definitions for the
exeption classes.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org