Re: svn commit: rev 5119 - in trunk/subversion: svnadmin include libsvn_fs tests tests/libsvn_fs tests/clients/cmdline/svntest libsvn_repos

Philip Martin <philip@codematters.co.uk> writes:

> I guess my question applies to the auth stuff as well. Why are these
> hashes popping up all of a sudden? What's the advantage to using a
> hash over a C structure?

In the case of libsvn_auth, there are N auth providers, any of which
might be registered within the auth baton. It's completely up to the
application to decide which providers are present.

Each provider needs specific runtime data... but because we don't know
which providers are present, it seems messy to have the auth_baton
contain a Giant C Structure that is the union of all possible runtime
parameters for all possible providers. And every time we write a new
provider, the C structure grows a bit, which might do icky things to
the API.

With a hash in the auth_baton, runtime data can be 'anonymously'
slipped to the correct provider in a discrete manner, provided key
namespaces are honored.

But it's a bikeshed to me. If people feel strongly, I can make the
auth_baton contain the Giant C Structure instead.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 26 22:03:46 2003