[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4847 - in trunk/subversion: include libsvn_client clients/cmdline libsvn_ra_svn libsvn_ra_dav

From: Branko Čibej <brane_at_xbc.nu>
Date: 2003-02-12 02:36:20 CET

rooneg@tigris.org wrote:

>Author: rooneg
>Date: 2003-02-11 17:51:27 -0600 (Tue, 11 Feb 2003)
>New Revision: 4847
>
>Modified:
> trunk/subversion/clients/cmdline/main.c
> trunk/subversion/include/svn_config.h
> trunk/subversion/libsvn_client/auth.c
> trunk/subversion/libsvn_client/client.h
> trunk/subversion/libsvn_ra_dav/fetch.c
> trunk/subversion/libsvn_ra_dav/ra_dav.h
> trunk/subversion/libsvn_ra_dav/session.c
> trunk/subversion/libsvn_ra_dav/util.c
> trunk/subversion/libsvn_ra_svn/client.c
>Log:
>Fix a few nits that Greg 'Eagle Eyes' Stein found in revision 4803.
>
...

>Modified: trunk/subversion/include/svn_config.h
>==============================================================================
>--- trunk/subversion/include/svn_config.h (original)
>+++ trunk/subversion/include/svn_config.h Tue Feb 11 17:51:32 2003
>@@ -47,6 +47,11 @@
> /** Opaque structure describing a set of configuration options. */
> typedef struct svn_config_t svn_config_t;
>
>+/** Config category corresponding to the ~/.subversion/config file. */
>+#define SVN_CONFIG_CATEGORY_CONFIG "config"
>+
>+/** Config category corresponding to the ~/.subversion/servers file. */
>+#define SVN_CONFIG_CATEGORY_SERVERS "servers"
>
> /** Read configuration information from all available sources and merge it
> * into one @c svn_config_t object.
>
>
What's wrong with just moving SVN_CONFIG__USR_CONFIG_FILE and
SVN_CONFIG__USR_SERVERS_FILE here from config_impl.h? Then the
categories and file names could just be the same thing. I'd even use the
same constants for the registry key names, regardless of (inconsistent?)
capitalization.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Feb 12 02:37:13 2003

This is an archived mail posted to the Subversion Dev mailing list.