Re: [patch] : configure time default editor

David Kimdon <dwhedon@debian.org> writes:

> Anyway, here is a patch that gives a --with-editor option to configure. I want
> this personally so I can close two bugs in the Debian package (
> http://bugs.debian.org/162632 , http://bugs.debian.org/164371 ). Up until now
> I have been using /etc/subversion/config to set the editor, but I'd rather use
> the vanilla 'config' file (especially since I sometimes forget to set the
> default editor when I update the 'config' template).
>
> How do we feel about this patch?

It looks like a reasonable idea to me. It caused me to look at the
current code (svn_cl__edit_externally) and I see

  /* Now, override this editor choice with a selection from our config
     file (using what we have found thus far as the default in case no
     config option exists). */

I don't think that's right -- I think the environment variables should
override the config file. The config should allow me to define the
default editor, but suppose I need to change it for a single commit.
If the config file dominates then I need to edit it twice, once for
the special case and once to restore it. That's silly, I should be
able to do

$ SVN_EDITOR=/some/one/off svn commit

What do people think?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org