[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4780 - in trunk/subversion: include libsvn_wc libsvn_client tests/clients/cmdline

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2003-02-07 19:30:17 CET

Eric Gillespie <epg@tigris.org> writes:
> +svn_boolean_t
> +svn_wc_is_ignored (const char *path,
> + apr_array_header_t *ignores)
> +{
> + int i;
> +
> + for (i = 0; ignores && (i < ignores->nelts); i++)
> + {
> + const char *pat = (((const char **) (ignores)->elts))[i];
> +
> + if (APR_SUCCESS == apr_fnmatch (pat, path, FNM_PERIOD))
> + return TRUE;
> + }
> +
> + return FALSE;
> +}

Was it Brane who pointed out earlier that this function is really a
generic looper to match a path across fnmatch patterns? Not saying it
should be moved right now; just making a mental note that if we find
another situation where we're matching a filename against a list of
patterns, probably we should genericize this and move it to svn_path.h
and libsvn_subr/path.c...

Anyway, nice fix (& regression test, too, yay).

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Feb 7 20:01:03 2003

This is an archived mail posted to the Subversion Dev mailing list.