[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVNSERVE Tests Failing

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2003-02-01 22:34:32 CET

Am i missing something, or is this known to be broken on both
ra_svn and ra_dav? Is it the general policy of this project for
the trunk to be broken for days? If this is a mistake, that's
one thing, but it looks like this is known breakage, which makes
it hard for people working on other things. Shouldn't this kind
of thing happen on a branch?

What i see is libsvn_client/commit.c:66 doing this:

  SVN_ERR (editor->apply_text (file_baton, NULL, NULL, NULL, contents,
                               editor, pool));

But apply_text is NULL:

static const svn_delta_editor_t ra_svn_editor = {
  ra_svn_target_rev,
  ra_svn_open_root,
  ra_svn_delete_entry,
  ra_svn_add_dir,
  ra_svn_open_dir,
  ra_svn_change_dir_prop,
  ra_svn_close_dir,
  ra_svn_add_file,
  ra_svn_open_file,
  ra_svn_apply_textdelta,
  NULL, /* ### todo#510: implement ra_svn_apply_text() */
  ra_svn_change_file_prop,
  ra_svn_close_file,
  ra_svn_close_edit,
  ra_svn_abort_edit
};

I look in svn_ra_dav__get_commit_editor and it isn't even initializing
it to NULL, which means that for ra_dav apply_text contains a random
value!

Again, am i missing something? Please tell me this hasn't been
intentionally broken since Wednesday.

--
Eric Gillespie <*> epg@pretzelnet.org

Build a fire for a man, and he'll be warm for a day. Set a man on
fire, and he'll be warm for the rest of his life. -Terry Pratchett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Feb 1 22:35:09 2003

This is an archived mail posted to the Subversion Dev mailing list.