[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 4342 - trunk/tools/hook-scripts

From: Matt Kraai <kraai_at_alumni.cmu.edu>
Date: 2003-01-11 17:01:56 CET

On Sat, Jan 11, 2003 at 03:33:10AM -0600, gstein@tigris.org wrote:
> Modified: trunk/tools/hook-scripts/mailer.py
> ==============================================================================
> --- trunk/tools/hook-scripts/mailer.py (original)
> +++ trunk/tools/hook-scripts/mailer.py Sat Jan 11 03:32:58 2003
> @@ -21,6 +22,7 @@
>
> SEPARATOR = '=' * 78
>
> +
> def main(pool, config_fname, repos_dir, rev):
> cfg = Config(config_fname)
>
> @@ -45,22 +47,60 @@
> def determine_output(cfg, repos, changes):
> ### process changes to determine the applicable groups
>
> + if cfg.is_set('general.mail_command'):
> + subject = mail_subject(cfg, repos, changes)
> + return PipeOutput(cfg, subject)
> +
> ### selecting SMTP will be more than this, but this'll do for now
> - if hasattr(cfg.general, 'smtp_hostname'):
> - return SMTPOutput(cfg)
> + if cfg.is_set('general.smtp_hostname'):
> + subject = mail_subject(cfg, repos, changes)
> + return SMTPOutput(cfg, subject)
>
> return StandardOutput()
>
>
> -class SMTPOutput:
> - def __init__(self, cfg):
> - import cStringIO
> +def mail_subject(cfg, repos, changes):
> + subject = 'rev %d - DIRS-GO-HERE' % repos.rev
> + if cfg.general.subject_prefix:

Why isn't this

  if cfg.is_set('general.subject_prefix')

?

Matt

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jan 11 17:02:56 2003

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.