Re: [PATCH] Add repository UUIDs (fixes issue 1037)

mark benedetto king <bking@answerfriend.com> writes:

> This patch stores a UUID in the "svn:uuid" revprop on revision 0
> Because the UUID should be immutable, an error is returned from
> calls to svn_repos_fs_change_rev_prop for this property.
>
> This enhancement was requested in issue 1037.
>
> * subversion/include/svn_props.h
> Add a new #define, SVN_PROP_REVISION_UUID.
>
> * subversion/libsvn_repos/hooks.c
> (svn_repos_fs_change_rev_prop): Return an error if the property
> is SVN_PROP_REVISION_UUID.
>
> * subversion/libsvn_repo/repos.c
> #include apr_uuid.h for apr_uuid_*
> (set_repos_uuid): new static function
> (svn_repos_create): call set_repos_uuid

How is this going to work when a repository is dumped/loaded? Should
a dump/load change the UUID? Should the UUID be dumped? There would
appear to be cases where we want the loaded repository to have the
same UUID as the dumped repository, and other cases where they should
be distinct.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org