Re: Default global-ignores setting

cmpilato@collab.net writes:

> Eric Gillespie <epg@pretzelnet.org> writes:
>
> > <brane@xbc.nu> writes:
> >
> > > Not so. It's not only about editing files, it's also about unit testing
> > > the chantes to make sure that they actually work. If you come up with a
> > > patch, and a description of how you tested it, that can save other
> > > people a lot of time. Really.
> >
> > Index: subversion/libsvn_wc/status.c
> > ===================================================================
> > --- subversion/libsvn_wc/status.c (revision 4007)
> > +++ subversion/libsvn_wc/status.c (working copy)
> > @@ -45,7 +45,7 @@
> >
> > SVN_ERR (svn_config_read_config (&cfg, pool));
> > svn_config_get (cfg, &val, "miscellany", "global_ignores",
> > - "*.o *.lo *.la #*# *.rej *~ .#*");
> > + "*.o *.lo *.la #*# *.rej .*.rej *~ .*~ .#*");
> > *patterns = apr_array_make (pool, 4, sizeof (const char *));
> > svn_cstring_split_append (*patterns, val, "\n\r\t\v ", FALSE, pool);
>
> This patch is incomplete. The default values written to the config
> file should also be changed to reflect these same additions.

I was thinking of a patch to remove the hard-coded default, and to
update the config file template.

I don't know whether the regression tests will pass if this is done,
which is what makes the task more than trivial. Ideally the tests
would pass whatever I have in my config file, but at the very least I
would want them to pass if I have no global_ignores in my config file.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org