Re: svn commit: rev 3964 - in trunk: . subversion subversion/libsvn_ra subversion/include subversion/tests/clients/cmdline/getopt_tests_data subversion/libsvn_ra_svn subversion/svnserve

On Tue, 2002-12-03 at 05:36, Greg Stein wrote:
> On Mon, Dec 02, 2002 at 09:55:50PM -0600, ghudson@tigris.org wrote:
> >...
> > Modified:
> > trunk/build.conf
> > trunk/configure.in
>
> -1
>
> This code should not be part of the default build (for now)

Okay... but I think you broke the build and the test suite by reverting
just these two files. I'll fix that.

> * the socket stuff needs to be apr-ized

Oh, hey, there's APR socket stuff! I somehow just assumed that Apache
used its own socket stuff. And it looks like I can turn an apr_file_t *
into a socket at least on Unix, which will allow pipe operation to
work. I'll get right on that.

> * this code has never been seen before; 150k is a *huge* amount of code to
> appear from nowhere and suddenly become part of the build

Yes and no. As a new RA layer, it doesn't affect anyone who doesn't use
it. I'm not sure how having it in the tree and not built is an
improvement on having it in the tree, built, and not used. (Branko
already volunteered to fix any Windows build problems, and the lack of
APR-ized sockets shouldn't actually be causing significant Windows build
problems.)

> But the non-apr-ized socket stuff is a problem, and I have serious
> issues with huge commits that nobody has ever seen before. I don't think
> that is a very good precedent, for anybody, no matter how good the code may
> or may not be.

I'm going to run into this issue again if I ever write libsvn_fs_fs (or
whatever it gets called). You can't exactly write an fs or ra layer as
a series of small commits, because you don't really know if your design
is going to work until you've written a good 60% of the code.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Dec 3 18:08:48 2002