Re: svn_path_is_url()

David Mankin <mankin@ants.com> writes:
> The comment in svn_path.h isn't any more help; it appears to be just
> plain wrong:
> /* Compare PATH to an array of const char * URL SCHEMES (like "file",
> "http", etc.) to determine if PATH looks like a URL. If so, return
> the matching scheme used by PATH, else return NULL. Returned
> values point to the allocations in SCHEMES. */
> svn_boolean_t svn_path_is_url (const char *path);

That comment is pretty confusing yeah. It shouldn't talk about the
internal implementation, just say that it returns true iff PATH is a
url in a known scheme.

> Anyone have any comments? I'm inclined to fix the comment in
> svn_path.h, and then fix the test case so it thinks ://blah/blah is
> invalid.

Seems like a good plan to me. Anyone know a reason why "://foo" is a
valid url?

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 26 17:32:37 2002