[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: RFC, PATCH issue 920 (svn:eol-style and eol consistency)

From: <cmpilato_at_collab.net>
Date: 2002-11-23 05:28:53 CET

David Kimdon <dwhedon@debian.org> writes:

> Fix issue 920:
>
> * subversion/libsvn_wc/props.c :
> (svn_wc_prop_set): Check files before setting a svn:eol-style property.
> If the file is binary or has inconsistent eol-style then don't set the
> property.
> (validate_eol_prop_against_file): New function.
>
> * subversion/tests/clients/cmdline/prop_tests.py :
> (inappropriate_props): Add tests to make sure svn:eol-style cannot be set on
> inappropriate files.

Well, David, your patch looked fine...but I chose to go about this
another way.

Because I implemented the keyword/newline transaction routines, I knew
that code for inconsistent EOL checking already existed. And because
Ben Collins-Sussman recently abstracted that translation interface to
use streams ... well, that means we could use the translation
routine's inconsistency checking without the penalty of an actual file
copy. So that's what I did.

However, as you can see in my forthcoming commit, your test case was
preserved, and certainly saved me some time there. I hope you aren't
offended, but the opportunity for code sharing was just too big for me
to miss. I mean, this fix *literally* took 40 minutes to code,
compile, and test. Which was a bummer, because it meant that for 20
minutes on the train, I had nothing to do. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Nov 23 05:31:57 2002

This is an archived mail posted to the Subversion Dev mailing list.