[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fs patch was vtable-fi-cation of the fs

From: Glenn A. Thompson <gthompson_at_cdr.net>
Date: 2002-11-22 03:37:29 CET

Hey,

By the way I totally agree with CMike's e-mail.

Garrett Rooney wrote:

> On Thursday, November 21, 2002, at 04:18 PM, Glenn A. Thompson wrote:
>
>> Hey,
>>
>> I just realized that this is a patch, and as such it should have
>> [PATCH] in the subject:-)
>> http://www.cdrguys.com/subversion/index.html
>
>
> i have almost no experience with the fs code, but i'm glancing over
> the diff, and a few things occured to me...
>
> basename_db_access_funcs_t
>
> what's with the name? first off, it should be namespace
> protected, so svn_ something, and i don't see the reason to lump
> 'baseline' at the front of it. i'd probably call it
> 'svn_fs_db_access_funcs_t' or something.

OH shit I missed that, svn_fs should precede it. I will fix it. I can't
believe I missed that one. As for the baseline thing. It want to
shorten it to bl. Now as to why. I view the existing FS as just that.
The baseline. I want FS developers to be free to write at the FS API
level or to write a DB backend against the existing logic. Or some
combination. The trail changes combined with this vtable should allow
it. The first SQL Backend will do just that. I don't think it will be
the best SQL solution but I think I can make it work well to start with.
 I'm sure there will be a few gotchas.
A next genration SQL FS may look quite a bit different.

>
> comments
>
> no need for the 'This gets included instead of bdb/xxx.h files'
> comments. that can go in the log or something, but there's no reason
> to enshrine it in the source forever...

I actually didn't expect people to want to commit it as is. I had
trouble deciding how and where to comment it.
I was leaving markers for those who know the existing code to grok what
I did. I'm happy to rip those comments.

>
>
> -garrett
>
I have to bail for now sorry. I will do a better job explaining my
ideas soon.

gat

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 22 03:36:14 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.