[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3757 - trunk/subversion/libsvn_wc

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-11-12 17:08:54 CET

brane@tigris.org writes:

> Modified: trunk/subversion/libsvn_wc/lock.c
> ==============================================================================
> --- trunk/subversion/libsvn_wc/lock.c (original)
> +++ trunk/subversion/libsvn_wc/lock.c Tue Nov 12 09:34:04 2002
> @@ -105,8 +105,15 @@
> return SVN_NO_ERROR;
> }
>
> - return svn_error_createf (SVN_ERR_WC_LOCKED, 0, NULL,
> - "working copy locked: %s", adm_access->path);
> + err = svn_error_create (SVN_ERR_WC_LOCKED, 0, NULL,
> + "run 'svn cleanup' to remove locks;"
> + " type 'svn help cleanup' for details");

I don't think the library should refer to the command line client, as
the advice is not appropriate for any other client. The client itself
should trap SVN_ERR_WC_LOCKED and add an appropriate message.

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 12 17:09:41 2002

This is an archived mail posted to the Subversion Dev mailing list.