[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3741 - in trunk/subversion: libsvn_fs libsvn_wc libsvn_ra_local libsvn_client libsvn_repos libsvn_delta libsvn_ra_dav

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-11-12 13:49:11 CET

Greg Stein <gstein@lyra.org> writes:

> > +++ trunk/subversion/libsvn_ra_local/split_url.c Mon Nov 11 18:01:29 2002
> > @@ -29,7 +29,7 @@
> > const char *URL,
> > apr_pool_t *pool)
> > {
> > - svn_error_t *err;
> > + svn_error_t *err = SVN_NO_ERROR;

This change was unnecessary. (It is a remnant of an earlier approach
to clearing the error).

> > const char *candidate_url;
> > const char *hostname, *path;
> >
> > @@ -134,6 +134,8 @@
> > hacked this path down to a bare nub yet, so we'll chop off
> > the last component of this path. */
> > candidate_url = svn_path_remove_component_nts (candidate_url, pool);
> > + if (err)
> > + svn_error_clear (err);
> > }
>
> Woah! I think you want to reset err to NULL here. You don't want the
> follow-on stuff to refer to the error any more.

So this is not necessary either, unless there is a bug that was
present before I got there :)

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 12 13:50:04 2002

This is an archived mail posted to the Subversion Dev mailing list.