Re: svnlook diff fails on binary files:

cmpilato@collab.net wrote:
>
> Blair Zajac <blair@orcaware.com> writes:
>
> > Just to be beat this into the ground, when diff returns 2, svnlook
> > quits immediately and doesn't generate the entire diff for the
> > revision, hence our commit email will be lacking info.
>
> I don't understand. Every time I've ever run diff on a binary file,
> it either prints nothing (no diff) or "Binary files foo and bar
> differ". Is this not true for you?
>
> Oh, I see.
>
> % cd /usr/share/pixmaps
> % diff tycoon.png ximian_button_pill.png
> Binary files tycoon.png and ximian_button_pill.png differ
> % echo $?
> 2
>
> So, the problem isn't so much that diff is run on binary files, it's
> that we aren't discerning the meaning of the 2 error code in this
> case. And since error code 2 is a really generic error code for diff,
> the best thing to do is just to not diff binary files. Am I on track?

I'm more concerned that something has changed and we don't know it.
All of the svn logo's got checked in a while ago and we didn't see
svnlook fail on the diffs.

I don't know why svnlook diff is running diff on binary files in the
first place.

Here's a commit on a logo that was updated

http://subversion.tigris.org/servlets/ReadMsg?list=svn&msgId=189515

It's not clear to me, is the message

Binary files /tmp/.svnlook/trunk/notes/logo/256-colour/subversion_logo_hor-237x32.png.64128.00001(null) and trunk/notes/logo/256-colour/subversion_logo_hor-237x32.png differ

from diff or from svn and svn was smart enough not to diff the file?

Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org