[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 3665 - trunk trunk/ac-helpers

From: Blair Zajac <blair_at_orcaware.com>
Date: 2002-11-06 07:59:59 CET

Ben Collins-Sussman wrote:
>
> Justin Erenkrantz <jerenkrantz@apache.org> writes:
>
> > --On Tuesday, November 5, 2002 11:58 PM -0600 sussman@tigris.org wrote:
> >
> > > Modified: trunk/ac-helpers/svn-apache.m4
> > > ===================================================================
> > > =========== --- trunk/ac-helpers/svn-apache.m4 (original)
> > > +++ trunk/ac-helpers/svn-apache.m4 Tue Nov 5 23:58:27 2002
> > > @@ -10,6 +10,8 @@
> > >
> > > AC_DEFUN(SVN_FIND_APACHE,[
> > >
> > > +HTTPD_WANTED_MMN="$1"
> > > +
> >
> > I *think* this should be
> >
> > HTTPD_WANTED_MMN=$1
> >
> > because we don't want to place any quotes around this value. It's a
> > numeric, not a string.
> >
> > If it works right now, well, we might not want to change. -- justin
>
> It works for me right now. So do the "$1"'s I committed in r3663.
>
> Can someone more knowledgable comment?

It doesn't hurt here because it's in the shell portion of the script and
isn't modified by m4.

The times we don't want ""'s are when you pass them to a m4 macro and
you want the $1 to white space separate the value, say with a

AC_DEFUN(AAA,[
for f in $1; do
  echo $f
done
])

Here calling AAA("a b") set f to "a b" and not to "a" and then "b".

Best,
Blair

-- 
Blair Zajac <blair@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 6 08:00:23 2002

This is an archived mail posted to the Subversion Dev mailing list.