[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Need help with this DAV stuff

From: Philip Martin <philip_at_codematters.co.uk>
Date: 2002-11-06 00:18:44 CET

Peter Davis <peter@pdavis.cx> writes:

> I don't think this is just in merge! A while back I posted this:
>
> http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgId=198530
>
> On Tuesday 05 November 2002 14:54, Philip Martin wrote:
> > The error is intermittent! I have captured the neon logs from a run
> > where it works and run where it fails. Here's part of the diff between
> > the two logs
> >
> > 65c65
> > < <S:remove-prop name="@ :@@ :@o"/>
> > ---
> >
> > > <S:remove-prop name=""/>
> >
> > Which looks like rubbish.

I think mod_dav_svn/update.c:upd_change_xxx_prop needs to apr_pstrdup
name. It calls apr_xml_quote_string but that doesn't reallocate if
there is nothing to quote. Comparing the value stored in
upd_change_xxx_prop with that used in close_helper shows a change, and
adding an apr_pstrdup cures the problem.

Is this the correct fix? Am I just hiding the bug? What's the
lifetime of the name argument to upd_change_xxx_prop?

-- 
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 6 00:19:33 2002

This is an archived mail posted to the Subversion Dev mailing list.