[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: new mem-management for libsvn_fs?

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2002-11-01 00:03:12 CET

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> > The real work here is going through every single txn_body_ routine,
> > and teaching it to make 'deep' copies of return-data into the return
> > pool. Before I start this, I want Old Hundred Eyes to agree that this
> > is a good approach. :-) cmpilato and I think it's the way to go.
>
> These two eyes are crying with joy :-).

Actually, gstein has a much better method.

Get this:

  * create a 2nd pool in each trail called 'scratchpool'.

  * make sure that commit_trail() frees trail->scratchpool.

  * now slowly, leisurely, teach each dag function to use
    trail->scratchpool for temporary work, and trail->pool for
    return-data.

This allows us to incrementally improve our memory usage, by rewriting
dag routines one-at-a-time.... very carefully.

*This* solution makes mine eyes cry with joy. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 1 00:06:17 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.