Re: [PATCH] DESTDIR support for python swig targets

> Isn't $(prefix) typically an absolute path like "/usr" or "/usr/local"?

Indeed.

> And actually, isn't $(prefix) just plain wrong in this instance? I
> mean, $(prefix) is the install location for Subversion itself, which
> might be completely different than where I want my Python modules
> dumped.

It depends on what we're expecting to achieve. On one hand, if a user
wants to install subversion on /usr/local, he could expect everything
to be installed there. On the other hand, when he installs a python
module under /usr/local, his python most probably won't find his modules
without sys.path hacking.

> What's the difference between DESTDIR and prefix? Perhaps we need
> only DESTDIR (and lose the prefix) here?

It's an option (you mean to use a fixed prefix, like /usr, right?).

I have some observations about the patch though:

> > install-swig-py-ext:
> > (cd $(SWIG_BUILD_DIR)/python; \
> > $(PYTHON) $(SWIG_SRC_DIR)/python/setup.py \
> > -S$(SWIG_SRC_DIR) \
> > - install --prefix $(prefix))
> > + install --prefix $(DESTDIR)$(prefix))

DESTDIR feets pretty well with distutil's install --root parameter:

  --root install everything relative to this alternate root
                      directory

-- 
Gustavo Niemeyer
[ 2AAC 7928 0FBF 0299 5EB5  60E2 2253 B29A 6664 3A0C ]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org