Re: svn commit: rev 3514 - trunk/subversion/libsvn_subr

Karl Fogel wrote:

>brane@tigris.org writes:
>
>
>>* subversion/libsvn_subr/io.c (svn_io_copy_file): Disable permission copying
>>on Windows, as it was before r3484.
>>
>>
>
>Shouldn't we maybe
>
> 1. Fix the documentation in apr/include/apr_file_io.h to indicate
> that apr_file_info_get() can return APR_INCOMPLETE
>
I thought that was clear for all functions returning file info,
including this one and apr_stat.

>and possibly:
>
> 2. Check for that APR_INCOMPLETE in the copy_perms!=0 case in
> svn_io_copy_file()
>
I don't think so. I'd rather leave the warning in, and later fix
apr_file_copy to copy permissions on Windows; it shouldn't be too hard.

>In any case, the comment added in this change is a bit misleading.
>svn_io_copy_file() no longer asks apr_file_copy() to copy perms, so
>the only issue here is with apr_file_info_get().
>
Ah, but according to the New Plan we'll go back to asking apr_file_copy
to copy the permissions. My comment is future-proof. :-)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org