kfogel@tigris.org writes:
> + if (translation_prop_changed)
> + {
> + const char *tmptext = svn_wc__text_base_path (base_name, TRUE, pool);
> +
> + /* A log command which copies and DEtranslates the working file
> + to a tmp-text-base. */
> + svn_xml_make_open_tag (&log_accum, pool,
> + svn_xml_self_closing,
> + SVN_WC__LOG_CP_AND_DETRANSLATE,
> + SVN_WC__LOG_ATTR_NAME, base_name,
> + SVN_WC__LOG_ATTR_DEST, tmptext,
> + NULL);
> +
> + /* A log command that copies the tmp-text-base and REtranslates
> + the tmp-text-base back to the working file. */
> + svn_xml_make_open_tag (&log_accum, pool,
> + svn_xml_self_closing,
> + SVN_WC__LOG_CP_AND_TRANSLATE,
> + SVN_WC__LOG_ATTR_NAME, tmptext,
> + SVN_WC__LOG_ATTR_DEST, base_name,
> + NULL);
> + }
Is this log file atomic? If the log file fails, or is interrupted,
during the the second copy and translate is it possible that base_name
is incomplete? That would mean that when cleanup reruns the log file
it will not prodoce the correct result.
If possible, the first copy and translate should be run outside of the
log file as it doesn't modify the working copy. That may mean that
some care has to be taken that the right properties are visible. Then
the log file need only contain the second copy and translate, and if
it is interrupted it should be safe to rerun it.
--
Philip Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 23 00:20:57 2002