[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: $EDITOR idea

From: <cmpilato_at_collab.net>
Date: 2002-10-03 18:46:52 CEST

Ben Collins-Sussman <sussman@collab.net> writes:

> > > On IRC, we discussed an idea about the $EDITOR text.
> > >
> > > The current $EDITOR behaviour adds an "SVN: " string to the front of
> > > 'svn status' output. To make it easier to create a log message, it
> > > would be nice to also chop off the file after a special marker.
> > > Something like this:
> >
> > -0.5. The presence of a repeating line-begin string like SVN: is
> > really easy for the eye to notice as interesting. I don't think a
> > single occurrence of a magic string is as eye-catching.
>
> I'm definitely against putting the diffs into the default log message.
>
> The complaint that users are making is that it's annoying to manually
> remove every "SVN:" prefix from each 'M foo.c' line that they want to
> annotate. It's much easier to delete a *single* line and then edit
> away.

I don't know about you, but I have to edit each of those lines anyway
right now because the paths are always absolute ones. And they always
have some one-letter code that doesn't actually end up in my final log
message. And they are rarely in the order that I want them to be in.
In other words, I always end up using a quick macro to hack off the
first so many characters of, and prepend '* ' to, each line anyway. 4
more characters to remove is a negligible cost.

You have the power to set $EDITOR to anything you want to -- set it to
a powerful editor that you know how to use. :-)

> I don't think "eye-catching" is something that needs worrying about.
> Think about every time you compose an email in Emacs: "--text follows
> this line--" appears, and you type below it. You don't have trouble
> noticing it. It's no big deal.

I don't have trouble noticing it because if I'm starting a new mail, I
hit "meta right-angle-bracket" and *poof* I'm where I need to be, and
if I'm replying to a mail, point is at the right place automatically.
But regardless, I get what your saying.

If it's a matter of choosing *either* the SVN: prefixes *or* some
magic line that means "from here down, things are toast", whatever,
but I don't see a need for both. I mean, I don't want our log message
handling to require more cycles than the commit itself. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 3 18:48:04 2002

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.