Re: [PATCH] [updated] [Issue 870] import should set svn:executable automatically

Brian Denny wrote:

>On Mon, 30 Sep 2002, [UTF-8] Branko Čibej wrote:
>
>
>
>>Doesn't that simply mean that the greek state should encapsulate
>>executableness somehow? Changing these calls will just make the tests
>>slower.
>>
>>
>
>probably you already understand this better than i do, but let
>me be more explicit about what is going on, just to make sure
>we have the same understanding of the issue.
>
>'execute_and_verify_update' has a parameter called 'check_props'.
>when this value of this parameter is 1, it does a proplist on
>every file of the actual disk, and compares those properties
>on the properties found in the expected_disk. therefore the right
>props must be set on expected_disk. the only way i know how to do this
>is by calling
> tweak('kappa', props={'svn:executable', ''})
>
>if, OTOH, the value of 'check_props' is 0 (which is the more common
>case), then the prop must NOT be set on the expected_disk.
>
>furthermore, the prop must never be set on an expected_status
>(which is also created by copying the greek_state).
>
[etc.]

Ah, O.K., I understand now. We're missing bits in the test
infrastructure, it seems; but I think your solution is as good a stopgap
as any, until somebody decides to tune up the test modules again.

I'll test your patch on Windows, and if everything's fine, I'll commit it.

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org