Re: permissions (and other) problems

On Thursday, September 12, 2002, at 05:34 PM, Philip Martin wrote:

> Garrett Rooney <rooneg@electricjellyfish.net> writes:
>
>>> Either way, the interaction with a multi-threaded Subversion client
>>> needs to be considered, even if it's only to document what happens.
>>> E.g. to say that svn_set_cancelation_handler affects all threads or
>>> that svn_async_cancel affects one thread.
>>
>> that's a tough question. i'm tempted to say that svn_async_cancel
>> effects all threads, but i imagine it might be nice to have it only
>> effect the current thread...
>
> Assuming svn_async_cancel sets some global state, probably just a
> flag, the question then is when does it get reset? Does the SVN_ERR
> macro reset it after deciding to generate an error? Does the client
> have to call svn_async_clear?

i'm leaning towards having the client call svn_async_clear, since
otherwise, you could get in the situation where SVN_ERR reset the flag,
but the error that was returned was ignored by something further up the
call chain (but still inside an svn function). i believe there are
places where we do ignore errors explicitly, so it could theoretically
happen...

-garrett

-- 
garrett rooney                    Remember, any design flaw you're
rooneg@electricjellyfish.net      sufficiently snide about becomes
http://electricjellyfish.net/     a feature.       -- Dan Sugalski
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org