Re: [PATCH] --disable-swig argument for configure

On Sat, Sep 07, 2002 at 07:53:00PM -0400, Garrett Rooney wrote:
>...
> +AC_ARG_WITH(swig,
> + [AC_HELP_STRING([--with-swig],
> + [Try to find a suitable SWIG and build the
> SWIG

Yup. Your mailer killed the patch. Nice wrap there :-)

(while you'll be able to commit directly, it does make it hard for "us" to
 try out the patch... no matter; I'll just review/comment...)

> + bindings with it.])],
> +[
> + if test "$withval" = "no" ; then
> + SWIG_SUITABLE=no
> + else
> + AC_PATH_PROG(SWIG, swig, none)
> + SVN_CHECK_SWIG
> fi
> -fi
> -AC_SUBST(SWIG_BUILD_RULES)
> -AC_SUBST(SWIG_INSTALL_RULES)
> -AC_SUBST(SWIG_PY_INCLUDES)
> +],
> +[
> + AC_PATH_PROG(SWIG, swig, none)
> + SVN_CHECK_SWIG
> +])

It seems that SVN_CHECK_SWIG should take an optional directory. The
AC_PATH_PROG would move inside SVN_CHECK_SWIG (note that the two are always
paired in your code above).

$withval will be "no" if somebody says --with-swig=no or --without-swig.
$withval will be "yes" if they say --with-swig. $withval will contain VALUE
if they say --with-swig=VALUE.

The test conditions should consider the "yes" vs VALUE cases.

> +++ ac-helpers/swig.m4 Sat Sep 7 19:30:16 2002
> @@ -0,0 +1,36 @@
> +dnl check to see if SWIG is current enough.
> +dnl
> +dnl if it is, then check to see if we have the correct version of
> pyton.

s/pyton/python/

>...

In general, the patch is fine, but (if checked in now) could use a couple
small iterations.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org