Re: [PATCH] --disable-swig argument for configure

Justin Erenkrantz wrote:

>On Sat, Sep 07, 2002 at 04:07:02PM -0400, Garrett Rooney wrote:
>
>
>>Here's a patch that implements this option. It seems to work, and I'd
>>commit it now, but I'd like someone with a bit more autoconf knowledge
>>to look over it first and make sure I didn't make any stupid mistakes.
>>
>>
>
>+1. Looks fine.
>
>Only question I have is whether the option should be "--with-swig"
>rather than "--enable-swig" - I've never fully groked the rules on
>this, but my hunch is that it should be AC_ARG_WITH not AC_ARG_ENABLE.
>But, I don't care much either way. -- justin
>
>

It's --with-PACKAGE[=DIR] and --enable-FEATURE. SWIG is a package, not a
feature. And I *do* care, because lots of people will be confused if we
use the wrong switch. So, please make that --with-swig[=DIR] and
--without-swig.

(Note that --with-swig=no is the same as --without-swig, and that plain
--with-swig is the same as --with-swig=yes. No, you don't have to do
anything to make that work, autoconf will do it for you.)

-- 
Brane Čibej   <brane_at_xbc.nu>   http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org