[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] UTF-8 fourth round...

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-06-28 22:38:06 CEST

Marcus Comstedt <marcus@mc.pp.se> writes:
> Well, the exact log message would depend on what parts of the patch
> are applied, but in general something about "conversion of text strings
> between internal repesentation (UTF-8) and external representation
> (locale specific)" would be appropriate I suppose. Many of the
> changes are not directly related to these conversions of course, but
> are just about replacing direct APR calls with wrapper calls so that
> APR is not exposed to the internal representation of paths.

Um, the log message is what helps us *decide* what parts of the patch
to apply. We can always edit the log message appropriately if we
don't apply certain parts of the change... But not if there's nothing
to edit!

The text "conversion of text strings between internal repesentation
(UTF-8) and external representation (locale specific)" is a summary of
the change, but it isn't a log message. See the HACKING file, and run
"svn log" for examples of full log messages.

The log message is hugely important for anyone to understand the
change. It can save the reviewer acres of time. Please (pretty
please) post yours and/or attach it to issue #494...

Thanks,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jun 28 22:46:56 2002

This is an archived mail posted to the Subversion Dev mailing list.