[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2320 - branches/issue-745-dev/subversion/libsvn_fs branches/issue-745-dev/subversion/libsvn_fs/util

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-06-24 23:20:17 CEST

On Mon, Jun 24, 2002 at 03:12:03AM -0500, cmpilato@tigris.org wrote:
>...
> +++ branches/issue-745-dev/subversion/libsvn_fs/fs.h Mon Jun 24 03:11:57 2002
> @@ -159,6 +159,10 @@
> /*** "Delta" Offset/Window Chunk ***/
> typedef struct
> {
> + /* diff format version number ### at this point, "svndiff" is the
> + only format used. */
> + apr_byte_t version;
> +

Are there any packing/alignment issues arising from the insertion of this
byte (before the apr_size_t)? IOW, we aren't directly memcpy'ing this
structure into the stream, are we? My concern is alignment and possible
exceptions caused by that.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 24 23:20:28 2002

This is an archived mail posted to the Subversion Dev mailing list.