Re: svn commit: rev 2177 - trunk/tools/hook-scripts

On Wed, Jun 12, 2002 at 06:05:51PM -0700, Blair Zajac wrote:
> Greg Stein wrote:
> >
> > On Wed, Jun 12, 2002 at 07:27:49PM -0500, blair@tigris.org wrote:
> > >...
> > > +my @command = ($svnlook, $repos, 'rev', $rev, 'info');
> > > +my ($status, @svnlooklines) = &safe_read_from_pipe(@command);
> > > +if ($status) {
> > > + die join("\n", "$0: @command failed with this output:", @svnlooklines),
> > > + "\n";
> > > +}
> >
> > This six-line pattern is used over and over and over. Can you make it a
> > single function like so:
> >
> > @svnlooklines = &run_command($svnlook, $repos, ...);
> >
> > The function itself can 'die' and print the error and whatnot. This will
> > also simplify and streamline the interesting part of the script.
> >
> > Cheers,
> > -g
>
> Will do.
[snip]

Is it really necessary to add in "Will do." and quote over 200
lines of the scipt? (Same goes for Greg.)

-- 
Michael Wood <mwood@its.uct.ac.za>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org