On Sat, Jun 08, 2002 at 10:06:17AM -0700, Justin Erenkrantz wrote:
> On Sat, Jun 08, 2002 at 01:48:05PM +0100, Joe Orton wrote:
> > On Thu, Jun 06, 2002 at 11:20:29AM -0700, Justin Erenkrantz wrote:
> > > With this patch to neon and HEAD of httpd-2.0 and mod_deflate turned
> > > on, I can check out my own website under SVN control with gzip
> > > compression.
> > >
> > > So, I think most of the bugs are ironed out now. =)
> > >
> > > * src/ne_compress.c (do_inflate): If we have nothing left to inflate,
> > > do not try to re-execute the loop and inflate again. We would get a
> > > Z_BUF_ERROR in this case.
> >
> > Hmmm, I'm not sure it's quite this simple... this only works because
> > avail_in is guaranteed to be > 0 at the end of the stream because of the
> > unconsumed gzip trailer.
>
> Neon would try to inflate when avail_in was 0. If there is nothing
> left to inflate, why call it again? How is that valid? We're not
> yet guaranteed to be at the end of the stream because we're just
> inflating chunks.
Okay, that does make more sense (my interpretation of the inflate()
documentation in zlib.h was that inflate() should be called whilst it
continues to provide inflated output).
Thanks for tracking this down!
Regards,
joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 10 23:24:45 2002