[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2024...

From: <cmpilato_at_collab.net>
Date: 2002-06-04 00:36:35 CEST

Karl Fogel <kfogel@newton.ch.collab.net> writes:

> cmpilato@collab.net writes:
> > > /* (First, try to write a logfile directly in PATH.) */
> > > log_parent = path;
> > > - base_name = svn_stringbuf_create (SVN_WC_ENTRY_THIS_DIR, pool);
> > > + base_name = apr_pstrdup (pool, SVN_WC_ENTRY_THIS_DIR);
> > > err = svn_wc__open_adm_file (&log_fp, log_parent, SVN_WC__ADM_LOG,
> > > (APR_WRITE | APR_APPEND | APR_CREATE),
> > > pool);
> >
> > This should be just 'base_name = SVN_WC_ENTRY_THIS_DIR;' No need to
> > dup it.
>
> Thanks, good catch.
>
> (In general, do you want me to take care of these, or will you be
> committing the fixes? I'm happy to do it if it's easier for you to
> just fire off an email and forget about it. :-).

Wasn't planning on doing the fixes, but I can if it will be helpful to
you.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 4 00:36:13 2002

This is an archived mail posted to the Subversion Dev mailing list.