[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: rev 2069 - trunk/subversion/libsvn_client

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-06-03 20:52:38 CEST

jerenkrantz@tigris.org writes:
> Multi-line string constants need a " " at the end or the error message
> does not come out right. Add a period to the end of sentences. Add a
> missing word to one of the error messages.

Any reason not to put newlines in? Those error strings are longer
than 80 columns even if %s expands to the empty string :-).

I'm aware that you didn't introduce this problem, it was there before.
I'm just asking first, in case there is some reason that I haven't
thought of to not put line breaks.

-Karl

> Modified: trunk/subversion/libsvn_client/commit_util.c
> ==============================================================================
> --- trunk/subversion/libsvn_client/commit_util.c (original)
> +++ trunk/subversion/libsvn_client/commit_util.c Sun Jun 2 12:23:49 2002
> @@ -461,14 +461,14 @@
> if (! p_entry)
> return svn_error_createf
> (SVN_ERR_WC_CORRUPT, 0, NULL, pool,
> - "Entry for `%s' has no URL, and its parent directory does"
> - "not appear to be under version control", target);
> + "Entry for `%s' has no URL, and its parent directory does "
> + "not appear to be under version control.", target);
> if ((p_entry->schedule == svn_wc_schedule_add)
> || (p_entry->schedule == svn_wc_schedule_replace))
> return svn_error_createf
> (SVN_ERR_ILLEGAL_TARGET, 0, NULL, pool,
> - "`%s' is the child an unversioned (or not-yet-versioned)"
> - "directory. Try committing the directory itself",
> + "`%s' is the child of an unversioned (or not-yet-versioned) "
> + "directory. Try committing the directory itself.",
> target);
>
> /* Manufacture a URL for this TARGET. */
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 3 20:56:38 2002

This is an archived mail posted to the Subversion Dev mailing list.