[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC/PATCH] commit messages not 8-bit compatible

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-05-29 17:47:15 CEST

cmpilato@collab.net writes:
> Log messages are just revision properties, and Subversion claims
> support for binary property values. So, even if, client side, log
> messages were limited to 7bit (which I think should *not* happen), we
> would still see this bug when someone used the upper ASCII characters
> on some other property, e.g., a node's "svn:ignore" property value.

A few words about that.

Yeah, we should definitely support 8-bit chars in log messages. On
the repository side, the revision property value is quite capable of
storing it, because it can store any binary value, like Mike says.

A person's $EDITOR can presumably write any binary value too.

The first problem in the pipeline is that the `log_msg' variable to a
lot of internal functions is now `const char *' instead of stringbuf.
As long as people stick to UTF-8, this is fine. If we want true
binary log message support, we'll need to go back to stringbufs for
that data (not a difficult change).

The next problem in the pipeline (based on what Ulf Tigerstedt
encountered) is that the message has to be properly XML-encoded before
being sent over the wire -- necessary whether UTF-8 or full binary.

Ulf, want to try a patch that does one or both of these things?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 1 14:34:26 2002

This is an archived mail posted to the Subversion Dev mailing list.