[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [RFC/PATCH] commit messages not 8-bit compatible

From: Karl Fogel <kfogel_at_newton.ch.collab.net>
Date: 2002-05-30 17:22:29 CEST

Greg Hudson <ghudson@MIT.EDU> writes:
> > The first problem in the pipeline is that the `log_msg' variable to a
> > lot of internal functions is now `const char *' instead of stringbuf.
> > As long as people stick to UTF-8, this is fine. If we want true
> > binary log message support, we'll need to go back to stringbufs for
> > that data (not a difficult change).
>
> Some corrections:
>
> 1. svn_string_t, not svn_stringfuf_t, for arbitrary binary data

Good point.

> 2. Being safe for "8-bit data" is different from being safe for
> "binary data." No 8-bit character set uses the octet 0 (I'm pretty
> certain of that), so you can still use C strings for international text
> unless you want to support UTF-16 or some such.

Now now, that's not a correction, that's what I'm saying above :-).

(Does even UTF-16 have any zero bytes?)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 1 14:18:48 2002

This is an archived mail posted to the Subversion Dev mailing list.