[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: vsn-rsc-url adaptations

From: Greg Stein <gstein_at_lyra.org>
Date: 2002-06-01 00:31:24 CEST

On Fri, May 31, 2002 at 04:50:52PM -0500, Ben Collins-Sussman wrote:
>...
> I'm getting the same failure when I try to commit from a working copy
> that has all 'new style' vsn-rsc-urls in it. ra_dav requests the
> checked-in property of the parent dir, then tries to CHECKOUT the
> child's correct vsn-rsc-url, and *still* gets the same error.

And what is that error saying to you... that the resource is out of date.
Maybe the new logic is incorrect?

> gstein, can you remind me how the commit is supposed to work, in
> deltaV terms?

MKACTIVITY /an/activity
CHECKOUT /some/thing
PUT /some/thing
PROPPATCH /some/thing
MERGE /an/activity

Ah... You're sending "18.1" and the atoi() in your code is translating that
as revision 18. That isn't going to work so well :-)

So there are two things to do:

1) SVN_STR_TO_REV(const char *) ought to have a companion that will take a
   ptr/len pair and convert the whole thing (and produce an error if the
   entire text is not consumed).

2) you should change mod_dav_svn.c::SVN_DEFAULT_SPECIAL_URI to "!svn" so
   that you don't have overlapping special areas; you'll fail at the $svn
   portion, long before you ever try to parse an old node id as a revision.

Note that (2) was desired anyways, and will fix this specific problem. (1)
is a longer term fix; it would be acceptable to defer that as long as an
issue is filed.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Jun 1 14:10:14 2002

This is an archived mail posted to the Subversion Dev mailing list.