Re: svn commit: rev 1957 - trunk/subversion/include trunk/subversion/libsvn_wc

Greg Stein <gstein@lyra.org> writes:
> > +/* Set to either TRUE or FALSE to indicate if a file is a module.
> > + ### This should be automatically inherited from the parent
> > + directory... which raises the general issue of property
> > + inheritance. */
> > +#define SVN_PROP_MODULE SVN_PROP_PREFIX "module"
>
> I highly disagree that this should be inherited.
>
> The concept of a "directory full of module descriptions" is only a
> convention. I do not believe we need to formalize that, or add in entire new
> concepts of property inheritance to support anything more than that.

What I'm afraid of is people add a new module file to a dir full of
modules files, but then it doesn't behave like a module because they
forgot to add the property.

   "Oh, they should read the docs!"

Yeah, but they added it in a directory called "modules", one can
hardly blame them... :-)

I don't think its absolutely necessary, but so far I see only plusses
and no minuses (except implementation time, and I wasn't saying we
should do it now).

Of course, it may be moot, if we don't do modules this way.

> For example, it might be really neat to drop a special developer's module
> file into tools/dev/. Regular Joe off the street just grabs the /trunk or
> whatever and is done.

Erp. I don't understand this example.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 15 01:19:13 2002